On 09/27/2011 06:39 AM, Eric Blake wrote:
On 09/26/2011 03:45 PM, Eric Blake wrote:
It can be seen that the <domain></domain> indent correctly.
I typed 'make check' in the tests directory. The
domainsnapshotxml2xmltest part output:
TEST: domainsnapshotxml2xmltest
...... 6 OK
PASS: domainsnapshotxml2xmltest
I'll take that as a series ack, and push the 14 patches then.
Actually, I'd feel more comfortable also getting a code review, and
not just a compile- and runtime-check test, since I am modifying some
internal APIs, and since I may have overlooked some lines not covered
by the particular <domain> that you tested.
Yeah, that's the second step I was going to do. I'll tell you once I had
done that. And maybe some questions to you if I encountered some
difficulties.
Thanks.
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list