Re: [PATCH] locking: remove redundant codes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/21/2011 07:15 PM, ajia@xxxxxxxxxx wrote:
From: Alex Jia<ajia@xxxxxxxxxx>

* src/locking/lock_driver_sanlock.c: remove redundant codes in error_unlink
   label from virLockManagerSanlockSetupLockspace, in fact, the codes make
   sure 'path' is non-null before getting to error_unlink label, so 'if (path)'
   is redundant, removing it in here and will also silence coverity.

I'd rather go with my more comprehensive patch, since it also fixes a mem leak:
https://www.redhat.com/archives/libvir-list/2011-September/msg00865.html

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]