On Wed, Sep 21, 2011 at 08:19:25 -0600, Eric Blake wrote: > On 09/21/2011 08:06 AM, Jiri Denemark wrote: > > The commit that prevents disk corruption on domain shutdown > > (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU > > 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed > > only recently in QEMU git. The affected versions of QEMU do not quit on > > SIGTERM if started with -no-shutdown, which we use to implement fake > > reboot. Since -no-shutdown tells QEMU not to quit automatically on guest > > shutdown, domains started using the affected QEMU cannot be shutdown > > properly and stay in a paused state. > > > > This patch disables fake reboot feature on such QEMU by not using > > -no-shutdown, which makes shutdown work as expected. However, > > virDomainReboot will not work in this case and it will report "Requested > > operation is not valid: Reboot is not supported with this QEMU binary". > > --- > > src/qemu/qemu_capabilities.c | 8 ++++++++ > > src/qemu/qemu_capabilities.h | 1 + > > src/qemu/qemu_command.c | 2 +- > > src/qemu/qemu_driver.c | 6 ++++++ > > 4 files changed, 16 insertions(+), 1 deletions(-) > > ACK. Thanks, I fixed qemuhelptest and qemuxml2argvtest and added one more qemuxml2argvtest for -no-shutdown and pushed. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list