Re: [PATCH 1/5] daemon: avoid memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/20/2011 03:03 AM, Eric Blake wrote:
On 09/18/2011 10:36 AM, ajia@xxxxxxxxxx wrote:
* daemon/remote.c: fix memory leak.

Your commit message didn't mention which function you fixed,...

Oh, I think 'git' will do this , and sorry about any inconvenient for you.

Thanks,
Alex


Signed-off-by: Alex Jia<ajia@xxxxxxxxxx>
---
  daemon/remote.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/daemon/remote.c b/daemon/remote.c
index 38bbb10..45244f8 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -997,6 +997,8 @@ cleanup:

and git didn't list it either, so I had to look. I tweaked the commit message to mention remoteDispatchDomainBlockStatsFlags, and that the leak was introduced in commit efa7fc9.

              VIR_FREE(ret->params.params_val);
          }
      }
+    if (dom)
+        virDomainFree(dom);
      VIR_FREE(params);
      return rv;

ACK and pushed.


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]