On 09/18/2011 10:36 AM, ajia@xxxxxxxxxx wrote:
* src/qemu/qemu_command.c: fix memory leak. Signed-off-by: Alex Jia<ajia@xxxxxxxxxx> --- src/qemu/qemu_command.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e8b1157..45d55fc 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6540,7 +6540,6 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr caps, host = disk->src; port = strchr(host, ':'); if (!port) { - def = NULL;
Took me a few minutes of research to find when this stray line was introduced - we've had a leak on error since commit 036ad50 (0.8.7).
ACK and pushed. -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list