On 09/16/2011 03:51 AM, Michal Privoznik wrote:
If a domain has inactive XML we want to transfer it to destination when migrating with VIR_MIGRATE_PERSIST_DEST. In order to harm the migration protocol as least as possible, a optional cookie was chosen. --- diff to v2: -Fix substitution on wrong place src/qemu/qemu_migration.c | 81 ++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 76 insertions(+), 5 deletions(-)
Looks right to me, but I'd feel more comfortable with a second ACK from danpb. I'm also hesitant on whether we should apply this now, or wait to post-0.9.5. While it is fixing a design flaw, it is not a regression fix, and feels more like a feature addition - if Dan could run this through his TCK suite to ensure no migration regressions, I'd feel a bit better about taking it now.
-- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list