On Tue, Sep 13, 2011 at 06:14:32PM +0800, Daniel Veillard wrote: > This is a bit painful for example when starting virt-manager > it tends to clutter libvirtd.log with invalid operation on cpu pinning > for defined but not running domains. A priori those kind of errors > don't indicate an error when executing the command but on a precondition > for running the API, and honnestly while the application should report > it, logging it as an error in libvirtd.log is not really useful, > > Related bug: https://bugzilla.redhat.com/show_bug.cgi?id=590807 > > Daniel > > diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c > index 1a9fd82..c708ff7 100644 > --- a/daemon/libvirtd.c > +++ b/daemon/libvirtd.c > @@ -357,6 +357,7 @@ static int daemonErrorLogFilter(virErrorPtr err, int priority) > case VIR_ERR_NO_NWFILTER: > case VIR_ERR_NO_SECRET: > case VIR_ERR_NO_DOMAIN_SNAPSHOT: > + case VIR_ERR_OPERATION_INVALID: > return VIR_LOG_DEBUG; > } ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list