On Tue, Sep 06, 2011 at 09:58:35AM +0200, Peter Krempa wrote: > Dňa 6.9.2011 9:41, Daniel Veillard wrote / napísal(a): > >On Mon, Sep 05, 2011 at 02:33:40PM +0200, Peter Krempa wrote: > >>Patch e81778d6184f1850a10eb661eb756b50421d5ac4 introduces printing > >>file name on XML errors. This corrects the URL string to be NULL and > >>therefore to print an error message not containing bogus filename > >>"domain.xml". > >> > >>NULL is a valid parameter for the file name value, as the only usage is > >>for error handlers. Functions touching the value either in libxml2 or in > >>libvirt check this parameter for NULL and behave according to it. > > Well, I started that trend, and used that as a hint about what kind > >of XML paring might be failing. If you have a better idea on how to > >name that temporary "file" (it's actually a memory entity), but I'm > >not sure setting it as NULL is such an improvement, > > > >Daniel > > > The idea of this patch was to suppress printing domain.xml in the > error message and > stick with the default error message which stated only the line > number and was used > previously (it did not contain the filename). yeah I understand the intent > I'll have another look at this and try to come up with something > more descriptitve, if > it's possible. the problem is that the file has no name since it's in memory, but one could still try to give an hint about what it is. It's a bit weird and a case of usability, I might be wrong :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list