On Wed, Aug 31, 2011 at 04:26:10PM +0800, Osier Yang wrote: > The mainly changes are: > > 1) Update qemuMonitorGetBlockStatsInfo and it's children (Text/JSON) > functions to return the value of new latency fields. > 2) Add new function qemuMonitorGetBlockStatsParamsNumber, which is > to count how many parameters the underlying QEMU supports. > 3) Update virDomainBlockStats in src/qemu/qemu_driver.c to be > compatible with the changes by 1). I'm not sure we should extend the existing set of function used by GetBlockStats instead of creating new functions asking/looking for the full set of values. On one hand it's good to share the code, but on the other hand if this leads to more round-trip between libvirtd and qemu I would rather keep them separate. I.e. we should pay the extra cost only when asking for the extra data. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list