Re: [PATCH] virsh: improve send-key documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/01/2011 01:09 PM, Daniel P. Berrange wrote:
On Thu, Sep 01, 2011 at 12:49:50PM -0600, Eric Blake wrote:
On 09/01/2011 08:41 AM, Daniel P. Berrange wrote:
On Wed, Aug 31, 2011 at 08:49:28AM -0600, Eric Blake wrote:
The 'virsh man' description of send-key was incomplete and used the
old style (literal 'optional name' instead of '[name]' metasyntax).
Meanwhile, none of the other virsh help texts include examples, so
I moved it out of virsh help and into the man page.

* tools/virsh.pod (send-key): Give better details.
* tools/virsh.c (info_send_key): Drop example from here.
---

I think we have to describe the codesets a bit more too....

I like it.  Do I need to post a v2 for review, or is this an ACK if
I just merge your suggestions into my v1 before pushing?

ACK Just go for it...

Pushed.

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]