On Thu, Sep 01, 2011 at 04:14:13PM +0800, Osier Yang wrote:
> * src/qemu/qemu_driver.c - qemuDomainSaveInternal: Return directly
> will keep the domain object locked.
> ---
> src/qemu/qemu_driver.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 4e8c691..a150b08 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -2223,7 +2223,7 @@ qemuDomainSaveInternal(struct qemud_driver *driver, virDomainPtr dom,
> if (qemuProcessAutoDestroyActive(driver, vm)) {
> qemuReportError(VIR_ERR_OPERATION_INVALID,
> "%s", _("domain is marked for auto destroy"));
> - return -1;
> + goto cleanup;
> }
>
> memset(&header, 0, sizeof(header));
ACK, I came to the same conclusion, and verified the same patch,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list