On 08/19/2011 03:58 PM, Eric Blake wrote:
Adds an optional element to<domainsnapshot>, which will be used to give user control over external snapshot filenames on input, and specify generated filenames on output. @@ -11044,6 +11110,19 @@ virDomainSnapshotDefParseString(const char *xmlStr, def->description = virXPathString("string(./description)", ctxt); + if ((i = virXPathNodeSet("./disks/*)", ctxt,&nodes))< 0)
Typo. Squash this in: diff --git i/src/conf/domain_conf.c w/src/conf/domain_conf.c index c9daebb..40ba564 100644 --- i/src/conf/domain_conf.c +++ w/src/conf/domain_conf.c @@ -11137,7 +11137,7 @@ virDomainSnapshotDefParseString(const char *xmlStr, def->description = virXPathString("string(./description)", ctxt); - if ((i = virXPathNodeSet("./disks/*)", ctxt, &nodes)) < 0) + if ((i = virXPathNodeSet("./disks/*", ctxt, &nodes)) < 0) goto cleanup; def->ndisks = i; if (def->ndisks && VIR_ALLOC_N(def->disks, def->ndisks) < 0) { -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list