On Mon, Aug 01, 2011 at 04:51:38PM +0800, Wen Congyang wrote: > At 07/30/2011 03:02 PM, Daniel Veillard Write: > > I actually tagged and pushed the rc2 tarball and rpms yesterday > > but completely forgot to send the associated mail, oops ! > > > > ftp://libvirt.org/libvirt/libvirt-0.9.4-rc2.tar.gz > > > > Hopefully it fixes most of the problems raised with rc1, including > > a number of leaks. Please report and if you had an issue with rc1 > > which is still not fixed there (or in git) please raise it ASAP. > > I'm planning for the final release early Tuesday 2 morning (i.e. > > late Monday for most :-) > > If client(for example: virsh) exits unexpectedly, it will cause libvirtd > crashed. > > Steps to reproduce this problem(vm1 does not run): > 1. for ((i=0; i < 50; i++)); do virsh managedsave vm1 & done; killall virsh > > The reason is that we free virNetServerClient when the refs is not 0. > > I read the code under the directory src/rpc/, and find we have xxxRef(), but > we do not have xxxUnref(). And sometimes we free the data structure if ref is > not 0. We add an reference of the data structure, but sometimes we forget to > unref it. Okay, so I count 3 issues we should fix before pushing 0.9.4 out - this one (can you open a bugzilla for tracking), are you gonna provide a patch ? Dan Berrange won't be around today - fix crash when mixing sync and async monitor jobs, we are waiting on Eric's finding of his v3 version - domabort seems broken in rc2 https://bugzilla.redhat.com/show_bug.cgi?id=727047 thanks for the heads-up ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list