Re: [PATCH] build: Use $(PYTHON) instead of python for the keycode map generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 22, 2011 at 08:06:00AM -0600, Eric Blake wrote:
> On 07/22/2011 07:56 AM, Matthias Bolte wrote:
> >Also prepend $(AM_V_GEN).
> >---
> >  src/Makefile.am |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/src/Makefile.am b/src/Makefile.am
> >index 481caba..eef0669 100644
> >--- a/src/Makefile.am
> >+++ b/src/Makefile.am
> >@@ -90,7 +90,7 @@ EXTRA_DIST += $(srcdir)/util/virkeymaps.h $(srcdir)/util/keymaps.csv \
> >
> >  $(srcdir)/util/virkeymaps.h: $(srcdir)/util/keymaps.csv	\
> >  		$(srcdir)/util/virkeycode-mapgen.py
> >-	python $(srcdir)/util/virkeycode-mapgen.py<$(srcdir)/util/keymaps.csv>$@
> >+	$(AM_V_GEN)$(PYTHON) $(srcdir)/util/virkeycode-mapgen.py<$(srcdir)/util/keymaps.csv>$@
> 
> ACK.

  Ah right, I missed that !

> Hmm, while you're at it, how about you also:
> 
> chmod +x src/util/virkeycode-mapgen.py
> 
> to match our style of .py files being executable (even if we run
> them via $(PYTHON)).

  just wondering loud, if you change a file attribute like this will
git automatically detect it and all to "commit" the change or is there
some magic involved (yes I'm think thinking too much in terms of CVS !)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel@xxxxxxxxxxxx  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]