Noticed because of the recent xen break in commit 1edf5cc5 (fixed in 934fdcb3), which broke because it touched too many files, rather than focusing on just xen_driver.c. Renaming all xen callback structs makes it easier to grep for use of the callback structs, which in turn makes it easier to see what still remains in the goal of getting rid of the callback struct. And using C99 initialization syntax makes it less likely that future patches will needlessly try to patch too many files. Eric Blake (4): xen: cleanup callback struct xen: reduce callback special cases xen: make direct call when there is only one subdriver xen: drop unused callbacks src/xen/xen_driver.c | 186 ++++++++++++++++++---------------------------- src/xen/xen_driver.h | 63 ++++++---------- src/xen/xen_hypervisor.c | 52 ++++---------- src/xen/xen_inotify.c | 39 +---------- src/xen/xend_internal.c | 68 +++++++---------- src/xen/xend_internal.h | 6 ++ src/xen/xm_internal.c | 51 +++---------- src/xen/xs_internal.c | 45 ++---------- 8 files changed, 167 insertions(+), 343 deletions(-) -- 1.7.4.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list