Re: [PATCH v3 5/8] undefine: Implement internal API for libxl driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/18/2011 01:53 AM, Osier Yang wrote:
This is just similiar as changes on qemu driver.

* src/libxl/libxl_driver.c: New callback for libxl_driver,
new function libxlDomainUndefineFlags, and changes libxlDomainUndefine
as a wrapper of libxlDomainUndefineFlags.
---
  src/libxl/libxl_driver.c |   34 +++++++++++++++++++++++++++++++++-
  1 files changed, 33 insertions(+), 1 deletions(-)

ACK.

+    char *name = NULL;
      int ret = -1;

+    virCheckFlags(VIR_DOMAIN_UNDEFINE_MANAGED_SAVE, -1);

Oh, here you went with MANAGED_SAVE, instead of MANAGED_STATE in patch 4/8 v3. Double check that each patch in your series compiles cleanly before pushing.

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]