Re: [PATCH] flags: fix domain_conf migration regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/15/2011 01:05 PM, Eric Blake wrote:
> Commit 461e0f1a broke migration, because there was a code path
> that tried to enable an internal flag while still going through
> the public function.  Split the internal flag into a separate
> callback, and validate that flags do not overlap.
> 
> * src/conf/domain_conf.c (virDomainDefFormat): Split...
> (virDomainDefFormatInternal): ...to separate the flag check.
> (virDomainObjFormat): Adjust caller.
> ---
> 
> Two regression in one day; my track record is not good right now.
> I guess this goes to show I didn't test a migration :(

I got confirmation from Stefan on IRC that this fixes his migration
issue, so I'm pushing now, even though I'm still in the middle of my
migration tests.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]