2011/7/15 Eric Blake <eblake@xxxxxxxxxx>:
> Also fix a logic bug in xenXMDomain{Attach,Detach}DeviceFlags,
> where (flags & VIR_DOMAIN_DEVICE_MODIFY_CURRENT) is always false.
>
> * src/xen/xen_driver.c (xenUnifiedDomainXMLFromNative)
> (xenUnifiedDomainXMLToNative, xenUnifiedDomainBlockPeek): Reject
> unknown flags.
> * src/xen/xen_hypervisor.c (xenHypervisorOpen)
> (xenHypervisorGetDomainState): Likewise.
> * src/xen/xen_inotify.c (xenInotifyOpen): Likewise.
> * src/xen/xs_internal.c (xenStoreOpen, xenStoreDomainGetState)
> (xenStoreDomainReboot): Likewise.
> * src/xen/xend_internal.c (xenDaemonOpen, xenDaemonDomainReboot)
> (xenDaemonDomainCoreDump, xenDaemonDomainGetState)
> (xenDaemonDomainMigratePrepare, xenDaemonDomainSetVcpusFlags,
> xenDaemonDomainGetVcpusFlags, xenDaemonAttachDeviceFlags,
> xenDaemonDetachDeviceFlags): Likewise.
> (xenDaemonDomainGetXMLDesc): Prefer unsigned flags.
> * src/xen/xend_internal.h (xenDaemonDomainGetXMLDesc): Likewise.
> * src/xen/xm_internal.h (xenXMDomainGetXMLDesc): Likewise.
> * src/xen/xm_internal.c (xenXMDomainGetXMLDesc): Likewise.
> (xenXMOpen, xenXMDomainGetState, xenXMDomainSetVcpusFlags)
> (xenXMDomainGetVcpusFlags): Reject unknown flags.
> (xenXMDomainAttachDeviceFlags, xenXMDomainDetachDeviceFlags):
> Likewise, and avoid always-false conditional.
> * src/xen/xen_driver.h (XEN_MIGRATION_FLAGS): New define.
> ---
>
> v3: address concerns about migration and coredump flags
>
> src/xen/xen_driver.c | 18 +++++++++++++++---
> src/xen/xen_driver.h | 7 +++++++
> src/xen/xen_hypervisor.c | 8 ++++++--
> src/xen/xen_inotify.c | 4 +++-
> src/xen/xend_internal.c | 42 ++++++++++++++++++++++++++++++++++--------
> src/xen/xend_internal.h | 3 ++-
> src/xen/xm_internal.c | 33 ++++++++++++++++++++++++++-------
> src/xen/xm_internal.h | 2 +-
> src/xen/xs_internal.c | 12 +++++++++---
> 9 files changed, 103 insertions(+), 26 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list