Re: [PATCH 3/8] save: wire up trivial saveFlags implementations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/14/2011 08:24 AM, Eric Blake wrote:
> For all hypervisors that support save, the new API now performs
> the same functions as the old.
> 
> * src/libxl/libxl_driver.c (libxlDomainSave): Move guts...
> (libxlDomainSaveFlags): ...to new function.
> * src/test/test_driver.c (testDomainSave, testDomainSaveFlags):
> Likewise.
> * src/vbox/vbox_tmpl.c (vboxDomainSave, vboxDomainSaveFlags):
> Likewise.

VBox virDomainSave doesn't work (it doesn't honor the destination file
name), and worse has no counterpart virDomainRestore (making it
absolutely worthless!).  I will split this patch to instead remove
vbox's virDomainSave, instead of wrapping it.  Or maybe we'll change
vbox's save to instead serve as virDomainManagedSave.  But the end
result is that is should not be part of this patch.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]