On Wed, Jul 13, 2011 at 10:09:21 -0600, Eric Blake wrote: > On 07/13/2011 03:25 AM, Jiri Denemark wrote: > > When qemuMonitorCloseFileHandle is called in error path, we need to > > preserve the original error since a possible further error when running > > closefd monitor command is not very useful to users. > > --- > > src/qemu/qemu_monitor.c | 34 +++++++++++++++++++++++++--------- > > src/qemu/qemu_monitor.h | 3 ++- > > 2 files changed, 27 insertions(+), 10 deletions(-) > > > > > > > @@ -1962,22 +1962,34 @@ int qemuMonitorSendFileHandle(qemuMonitorPtr mon, > > > > > > int qemuMonitorCloseFileHandle(qemuMonitorPtr mon, > > - const char *fdname) > > + const char *fdname, > > + bool preserveError) > > Why the bool argument? Every one of the callers was adjusted to set it > to true, so if no one sets it to false, it seems like it makes more > sense to blindly preserveError instead of make it parameterizable, > without having to tweak any callers. I guess I just wanted to stress that qemuMonitorCloseFileHandle preserves the error :-) The simpler v2 follows... Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list