Re: [PATCHv2 02/27] maint: print flags in hex during debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/13/2011 03:49 AM, Matthias Bolte wrote:
> 2011/7/8 Eric Blake <eblake@xxxxxxxxxx>:
>> Continuation of commit 313ac7fd, and enforce things with a syntax
>> check.
>>
>> Technically, virNetServerClientCalculateHandleMode is not printing
>> a mode_t, but rather a collection of VIR_EVENT_HANDLE_* bits;
>> however, these bits are < 8, so there is no different in the
>> output, and that was the easiest way to silence the new syntax check.
>>
> 
> flags_debug
> src/libvirt-qemu.c:117:    VIR_DEBUG("conn=%p, pid=%u, flags=%u",
> conn, pid, flags);
> maint.mk: debug flag values with %x
> 
> Dan commited this after you posted your series. So ACK with that new
> offender fix too.

Yep, I noticed that while rebasing as well.

Fixed and pushed, along with patch 1/27.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]