On Mon, Jul 11, 2011 at 21:28:30 +0100, Daniel P. Berrange wrote: > On Fri, Jul 08, 2011 at 01:34:13AM +0200, Jiri Denemark wrote: > > Most of the code in these two functions is supposed to be identical but > > currently it isn't (which is natural since the code is duplicated). > > Let's move common parts of these functions into qemuMigrationPrepareAny. > > Were there any actual bugs fixed in this consolidation, or were > the differences in the code just cosmetic ? If so it'd be good to > mention the bugs fixed in the commit message Yes, I added the following to the commit message: This also fixes qemuMigrationPrepareTunnel which didn't store received lockState in the domain object. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list