On Fri, Jul 08, 2011 at 01:34:16AM +0200, Jiri Denemark wrote: > Make MIGRATION_OUT use the new helper methods. > > This also introduces new protection to migration v3 process: the > migration job is held from Begin to Confirm to avoid changes to a domain > during migration (esp. between Begin and Perform phases). This change, > however brings a small issue when Prepare step fails during normal (not > p2p or tunneled) migration when old client talks to new libvirtd. The > old client doesn't call Confirm (with cancelled == 1) to end the > migration job. I'm open to suggestions how to solve this in the best > way. My idea is to use flags for Begin3 and Perform3 that would enable > this extra protection by moving migration job start from Perform to > Begin phase while maintaining the old behavior if the flags are not set. > Note that virDomainAbortJob will be able to cancel migration in any > phase (i.e., not only in Perform phase). What do you mean by 'old client' in this context ? A v3 migration client from the 0.9.3 release, or a v2 migration client from a < 0.9.3 release Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list