Re: [PATCH 4/5] Fix leak of remote driver if final 'CLOSE' RPC call fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/08/2011 05:57 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> When closing a remote connection we issue a (fairly pointless)
> 'CLOSE' RPC call to the daemon. If this fails we skip all the
> cleanup of private data, but the virConnectPtr object still
> gets released as normal. This causes a memory leak. Since the
> CLOSE RPC call is pretty pointless, just carry on freeing the
> remote driver if it fails.
> 
> * src/remote/remote_driver.c: Ignore failure to issue CLOSE
>   RPC call
> ---
>  src/remote/remote_driver.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]