Re: [PATCH 4/8] cgroup: silence coverity warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At 2011-7-2 7:36, Eric Blake write:
Coverity noted that most clients reacted to failure to hash; but in
a best-effort kill loop, we can ignore failure.

* src/util/cgroup.c (virCgroupKillInternal): Ignore hash failure.
---
  src/util/cgroup.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/cgroup.c b/src/util/cgroup.c
index 2e5ef46..740cedf 100644
--- a/src/util/cgroup.c
+++ b/src/util/cgroup.c
@@ -1395,7 +1395,7 @@ static int virCgroupKillInternal(virCgroupPtr group, int signum, virHashTablePtr
                      done = false;
                  }

-                virHashAddEntry(pids, (void*)pid, (void*)1);
+                ignore_value(virHashAddEntry(pids, (void*)pid, (void*)1));
              }
              VIR_FORCE_FCLOSE(fp);
          }
ACK

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]