Hi, Eric
On Wed, 29 Jun 2011 11:52:41 -0600
Eric Blake <eblake@xxxxxxxxxx> wrote:
> Incorporating my own suggestions from earlier rounds of review.
> Minoru's original 2/2 patch is unchanged.
>
> I think this series is probably worth including in 0.9.3, since
> it is fixing a just-added feature, but won't push without feedback.
Thank you for your patches. I think these are good itself.
But my 2/2 patch depends on prior behaviour of virSkipSpacesBackwards().
In case of @str consists of only spaces, prior virSkipSpacesBackwards() set NULL pointer to @endp.
Your version set non-NULL but points to a NULL pointer.
So, the caller can't delete NULL element line like folloing.
<entry name='serial_number'></entry>
<entry name='part_number'></entry>
So I'll change 2/2 patch soon.
> Eric Blake (2):
> util: fix virSkipSpaces
> util: add virTrimSpaces
>
> Minoru Usui (1):
> sysinfo: delete unnecessary white space of sysinfo.
>
> src/libvirt_private.syms | 3 ++
> src/util/sysinfo.c | 21 +++++++++++++
> src/util/util.c | 76 +++++++++++++++++++++++++++++++++++++++++++--
> src/util/util.h | 5 +++
> src/xen/xend_internal.c | 4 +-
> 5 files changed, 103 insertions(+), 6 deletions(-)
>
> --
> 1.7.4.4
>
--
Minoru Usui <usui@xxxxxxxxxxxxxxxxx>
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list