Re: [PATCH 2/2] remote: protect against integer overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/24/2011 01:48 PM, Matthias Bolte wrote:
> 2011/6/24 Eric Blake <eblake@xxxxxxxxxx>:
>> Integer overflow and remote code are never a nice mix.
>>
>> This has existed since commit 56cd414.
>>
>> * src/libvirt.c (virDomainGetVcpus): Reject overflow up front.
>> * src/remote/remote_driver.c (remoteDomainGetVcpus): Avoid overflow
>> on sending rpc.
>> * daemon/remote.c (remoteDispatchDomainGetVcpus): Avoid overflow on
>> receiving rpc.

>> +#include "intprops.h"
> 
> I see this file in ./gnulib/lib but intprops is not listed in
> bootstrap.conf, so it's probably pulled in as a dependency for another
> module. But it doesn't hurt to be explicit and list it in
> bootstrap.conf.

Actually, I squashed that into patch 1/2.

> 
> ACK, with that fixed.

Thanks, and pushed.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]