On Tue, Jun 21, 2011 at 05:07:43PM +0800, Osier Yang wrote: > On 06/21/2011 04:55 PM, Michal Privoznik wrote: > >On 21.06.2011 07:37, Osier Yang wrote: > >>All of the following 7 commands just provide one option (--persistent) > >>for user to specify how to affect the domain: > >> attach-device > >> detach-device > >> attach-disk > >> detach-disk > >> attach-interface > >> detach-interface > >> update-device > >> > >>This patch add two new options (--live, --current), and changes > >>"--persistent" into "--config", just as other similar commands, > > >I am not fully convinced about this. I mean - it would be nice to have > >unified options names for these commands, but I am afraid we can't > >change them. > > That's what I'm worried about too, changing "--persistent" into > "--config" may affect already existed scripts based on virsh. But > considering the unification, it might be better to change it. > > Or perhaps we can just leave "--persistent" unchanged, but it > might be quite confused for user. We cannot remove an old flag, so --persistent has to stay. Now we can add an equivalent --config, which does the same for unification between commands, but removing --persistent will get a NACK from me :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list