This also reduces malloc pressure for invoking a child when VIR_DEBUG is enabled. * src/util/command.c (virExecWithHook): Drop debug, since the only caller (virCommandRunAsync) also prints debug info. --- Suggested here: https://www.redhat.com/archives/libvir-list/2011-May/msg00592.html src/util/command.c | 20 -------------------- 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/src/util/command.c b/src/util/command.c index 0f8ff14..1144392 100644 --- a/src/util/command.c +++ b/src/util/command.c @@ -296,26 +296,6 @@ virExecWithHook(const char *const*argv, int tmpfd; const char *binary = NULL; int forkRet; - char *argv_str = NULL; - char *envp_str = NULL; - - if ((argv_str = virArgvToString(argv)) == NULL) { - virReportOOMError(); - return -1; - } - - if (envp) { - if ((envp_str = virArgvToString(envp)) == NULL) { - VIR_FREE(argv_str); - virReportOOMError(); - return -1; - } - VIR_DEBUG("%s %s", envp_str, argv_str); - VIR_FREE(envp_str); - } else { - VIR_DEBUG("%s", argv_str); - } - VIR_FREE(argv_str); if (argv[0][0] != '/') { if (!(binary = virFindFileInPath(argv[0]))) { -- 1.7.4.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list