Re: [PATCH 10/12] build: silence coverity false positives

Matthias Bolte <matthias.bolte@xxxxxxxxxxxxxx> · Tue, 7 Jun 2011 15:46:04 +0200

2011/6/6 Eric Blake <eblake@xxxxxxxxxx>:
> Coverity complained about these intentional fallthrough cases, but
> not about other cases that were explicitly marked with nice comments.
>
> For some reason, Coverity doesn't seem smart enough to parse the
> up-front English comment in virsh about intentional fallthrough :)
>
> * tools/virsh.c (cmdVolSize): Mark fallthrough in a more typical
> fashion.
> * src/conf/nwfilter_conf.c (virNWFilterRuleDefDetailsFormat)
> (virNWFilterRuleDetailsParse): Mark explicit fallthrough.
> ---
> Âsrc/conf/nwfilter_conf.c | Â Â4 ++++
> Âtools/virsh.c Â Â Â Â Â Â| Â Â3 +++
> Â2 files changed, 7 insertions(+), 0 deletions(-)
>

ACK.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list