2011/6/6 Eric Blake <eblake@xxxxxxxxxx>: > Detected by Coverity. ÂCommit a98d8f0d tried to make uuid debugging > more robust, but missed some APIs. ÂAnd on the APIs that it visited, > the mere act of preparing the debug message ends up dereferencing > uuid prior to the null check. ÂWhich means the APIs which are supposed > to gracefully reject NULL arguments now end up with SIGSEGV. > > * src/libvirt.c (VIR_UUID_DEBUG): New macro. > (virDomainLookupByUUID, virDomainLookupByUUIDString) > (virNetworkLookupByUUID, virNetworkLookupByUUIDString) > (virStoragePoolLookupByUUID, virStoragePoolLookupByUUIDString) > (virSecretLookupByUUID, virSecretLookupByUUIDString) > (virNWFilterLookupByUUID, virNWFilterLookupByUUIDString): Avoid > null dereference. > --- > Âsrc/libvirt.c | Â 42 ++++++++++++++++++++++++++---------------- > Â1 files changed, 26 insertions(+), 16 deletions(-) > ACK. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list