Detected by Coverity. Bug introduced in commit 9d73efd (v0.8.8). * src/qemu/qemu_hotplug.c (qemuDomainChangeGraphics): Don't report error on success. --- I hate it when my ISP chokes on large patch series. Hopefully I'm threading this resend correctly. src/qemu/qemu_hotplug.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index fe47896..2154c36 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1117,6 +1117,7 @@ qemuDomainChangeGraphics(struct qemud_driver *driver, VIR_DEBUG("Not updating since password didn't change"); ret = 0; } + break; default: qemuReportError(VIR_ERR_INTERNAL_ERROR, -- 1.7.4.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list