Re: [PATCH] Don't raise an error if the migration cookie is NULL

[Matthias Bolte <matthias.bolte@xxxxxxxxxxxxxx>]

2011/6/4 Daniel P. Berrange <berrange@xxxxxxxxxx>:
> The v2 migration protocol doesn't use cookies, so we should not
> be raising an error if the cookie parameters are NULL.
>
> * src/qemu/qemu_migration.c: Don't raise error if cookie is NULL
> ---
> Âsrc/qemu/qemu_migration.c | Â Â7 ++-----
> Â1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index aa74d86..fa506e2 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -618,11 +618,8 @@ qemuMigrationBakeCookie(qemuMigrationCookiePtr mig,
> Â Â Â Â Â Â Â Â Â Â Â Â int *cookieoutlen,
> Â Â Â Â Â Â Â Â Â Â Â Â int flags)
> Â{
> - Â Âif (!cookieout || !cookieoutlen) {
> - Â Â Â ÂqemuReportError(VIR_ERR_INVALID_ARG, "%s",
> - Â Â Â Â Â Â Â Â Â Â Â Â_("missing migration cookie data"));
> - Â Â Â Âreturn -1;
> - Â Â}
> + Â Âif (!cookieout || !cookieoutlen)
> + Â Â Â Âreturn 0;
>
> Â Â *cookieoutlen = 0;

ACK.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list