Re: [PATCH 2/7] lxc: Don't report error in Wait/SendContinue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/02/2011 01:40 PM, Cole Robinson wrote:
> We will reuse these shortly, and each use should have a different error
> message.
> 
> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx>
> ---
>  src/lxc/lxc_container.c  |   15 ++++++---------
>  src/lxc/lxc_controller.c |    5 ++++-
>  2 files changed, 10 insertions(+), 10 deletions(-)

So basically you are hoisting the error message out of the low-level
routine into the caller, for preparation of reusing the low-level
routine from different contexts where the caller can print a better message.

ACK, but again post-release.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]