On Tue, 31 May 2011 14:50:30 -0600 Eric Blake <eblake@xxxxxxxxxx> wrote: > On 05/29/2011 07:54 PM, Minoru Usui wrote: > >>> So I wonder if we should add a parameter for the CPU num > >>> to the API: > >>> > >>> int virNodeGetCPUStats (virConnectPtr conn, > >>> int cpuNum, > >>> virCPUStatsPtr params, > >>> int *nparams, > >>> unsigned int flags); > >>> > >>> And have a constant for getting the host data as a whole: > >>> > >>> #define VIR_NODE_CPU_STATS_ALL_CPUS -1 > > >> That way the API and virsh command are ready for more precise use > >> and we won't need to make a second set of APIs. > >> > >> thanks ! > > > > OK. > > I'll add cpu/cell argments for more generalization. > > At this point, I'd feel more comfortable delaying this patch series (as > well the virNodeGetMemoryStats series) until after the 0.9.2 release. > Feel free to post v7 for review before them, but I think we've had > enough churn on the interface, and we've already hit the freeze with > release candidate 1, that I don't feel right pushing this upstream this > late in a release cycle, even though the principle idea has been ACK'd. I understand. I'll change my target to 0.9.3. -- Minoru Usui <usui@xxxxxxxxxxxxxxxxx> -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list