Re: [PATCH] remote generator: Handle some virTypedParameterPtr using functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/5/31 Eric Blake <eblake@xxxxxxxxxx>:
> On 05/30/2011 12:34 PM, Matthias Bolte wrote:
>> This doesn't cover the getters that allow to query nparams yet.
>> ---
>>
>> This patch depends on
>>
>> https://www.redhat.com/archives/libvir-list/2011-May/msg01856.html
>>
>> Âdaemon/remote.c       Â| Â182 -----------------------------------
>> Âdaemon/remote_generator.pl  |  58 +++++++++++-
>> Âsrc/remote/remote_driver.c  | Â215 ------------------------------------------
>> Âsrc/remote/remote_protocol.x | Â 20 ++--
>> Â4 files changed, 67 insertions(+), 408 deletions(-)
>
> Nice reduction in maintained code size!
>
> I got conflicts when trying this patch out, though, so you may have some
> rebase issues, but I think I resolved it correctly, and was able to
> verify that with this applied, the generated functions accurately
> replace the manual versions.

You might have missed one of the previous patches, because It applies
without problem for me.

> ACK.

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]