Re: [PATCH] Use common parameter order for remote(De)SerializeTypedParameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/5/31 Eric Blake <eblake@xxxxxxxxxx>:
> On 05/30/2011 12:33 PM, Matthias Bolte wrote:
>> We commonly use "value, length" order, let's stick to this.
>> ---
>> Âdaemon/remote.c      Â|  40 ++++++++++++++++++++--------------------
>> Âsrc/remote/remote_driver.c | Â 40 ++++++++++++++++++++--------------------
>> Â2 files changed, 40 insertions(+), 40 deletions(-)
>
> ACK. Â(Does it show that I built up the factored function incrementally,
> without realizing that the end result ended up going against convention?)
>

You might also just have matched the XDR on-the-wire ordering of arrays :)

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]