On 05/25/2011 02:54 AM, Hu Tao wrote:
> This enables users to modify memory parameters for inactive domains
> ---
> include/libvirt/libvirt.h.in | 7 +++++++
> tools/virsh.c | 26 +++++++++++++++++++++++---
> tools/virsh.pod | 7 +++++++
> 3 files changed, 37 insertions(+), 3 deletions(-)
> +/* flags for setting memory parameters */
> +typedef enum {
> + VIR_DOMAIN_MEMORY_PARAM_CURRENT = 0, /* affect current domain state */
> + VIR_DOMAIN_MEMORY_PARAM_LIVE = (1 << 0), /* affect active domain */
> + VIR_DOMAIN_MEMORY_PARAM_CONFIG = (1 << 1) /* affect next boot */
> +} virMemoryParamFlags;
This commit is already pushed, but our general style has been to include
the trailing comma in enum lists (this requires a C99 compiler, but we
require C99 for other reasons). It makes maintenance easier, because
then adding a new value does not require modifying the former last line
to add the comma, for a smaller diff.
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list