On Fri, May 27, 2011 at 11:26:00AM +0100, Daniel P. Berrange wrote:
> The virDomainHostdevDef struct contains a 'char *target'
> field. This is set to 'NULL' when parsing XML and never
> used / set anywhere else. Clearly it is bogus & unused
>
> * src/conf/domain_conf.c, src/conf/domain_conf.h: Remove
> target from virDomainHostdevDef
> ---
> src/conf/domain_conf.c | 2 --
> src/conf/domain_conf.h | 1 -
> 2 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 00c8058..f2e2aca 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -893,7 +893,6 @@ void virDomainHostdevDefFree(virDomainHostdevDefPtr def)
> if (!def)
> return;
>
> - VIR_FREE(def->target);
> virDomainDeviceInfoClear(&def->info);
> VIR_FREE(def);
> }
> @@ -4774,7 +4773,6 @@ virDomainHostdevDefParseXML(const xmlNodePtr node,
> virReportOOMError();
> return NULL;
> }
> - def->target = NULL;
>
> mode = virXMLPropString(node, "mode");
> if (mode) {
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 60e1704..da34770 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -792,7 +792,6 @@ struct _virDomainHostdevDef {
> int dummy;
> } caps;
> } source;
> - char* target;
> int bootIndex;
> virDomainDeviceInfo info; /* Guest address */
> };
ACK,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list