On Thu, May 26, 2011 at 12:17:42PM -0400, Laine Stump wrote: > From: Michal Privoznik <mprivozn@xxxxxxxxxx> > > No change from previously ACKed patch > diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs > index 414b4d5..a28cd13 100644 > --- a/src/remote_protocol-structs > +++ b/src/remote_protocol-structs > @@ -803,6 +803,15 @@ struct remote_interface_destroy_args { > remote_nonnull_interface iface; > u_int flags; > }; > +struct remote_interface_change_begin_args { > + unsigned int flags; > +}; > +struct remote_interface_change_commit_args { > + unsigned int flags; > +}; > +struct remote_interface_change_rollback_args { > + unsigned int flags; > +}; > struct remote_auth_list_ret { > struct { > u_int types_len; I had to fix this with the following commit as the generator expects u_int instead of unsigned int and a slightly different indentation. This was breaking make check for me, so I applied and pushed the following patch, as semantic should be the same and it's a make check breaker :-) Daniel commit a9a95cb14a2c3329643186ced21b0eaad0c46ed7 Author: Daniel Veillard <veillard@xxxxxxxxxx> Date: Sun May 29 18:21:24 2011 +0800 Fix a make check error Apparently introdunced in commit 376e1d9420b the generator produces u_int flags not unsigned int flags. * src/remote_protocol-structs: fix to the actual expected type and alignment diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 5b6a634..031e2f2 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -804,13 +804,13 @@ struct remote_interface_destroy_args { u_int flags; }; struct remote_interface_change_begin_args { - unsigned int flags; + u_int flags; }; struct remote_interface_change_commit_args { - unsigned int flags; + u_int flags; }; struct remote_interface_change_rollback_args { - unsigned int flags; + u_int flags; }; struct remote_auth_list_ret { struct { -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list