2011/5/26 Eric Blake <eblake@xxxxxxxxxx>:
> On 05/26/2011 12:06 PM, Matthias Bolte wrote:
>> This testcase passes before the regression is added in f0443765, fails
>> after that commit and passes again after the regression was fixed.
>> ---
>> Âsrc/openvz/openvz_conf.c  |  Â2 +-
>> Âsrc/openvz/openvz_conf.h  |  Â1 +
>> Âtests/Makefile.am     Â|  18 +++++++++
>> Âtests/openvzutilstest.c  Â|  91 ++++++++++++++++++++++++++++++++++++++++++++
>> Âtests/openvzutilstest.conf | Â 41 ++++++++++++++++++++
>> Â5 files changed, 152 insertions(+), 1 deletions(-)
>> Âcreate mode 100644 tests/openvzutilstest.c
>> Âcreate mode 100644 tests/openvzutilstest.conf
>
> More tests are always good.
>
>>
>> diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c
>> index 3e4844a..3dc6b37 100644
>> --- a/src/openvz/openvz_conf.c
>> +++ b/src/openvz/openvz_conf.c
>> @@ -645,7 +645,7 @@ openvzWriteVPSConfigParam(int vpsid, const char *param, const char *value)
>> Â *
>> Â * Returns <0 on error, 0 if not found, 1 if found.
>> Â */
>> -static int
>> +int
>> ÂopenvzReadConfigParam(const char *conf_file, const char *param, char **value)
>
> Will this work with './configure --with-driver-modules', or do we also
> need to add it to some libvirt_xxx.syms somewhere?
>
> [Speaking of --with-driver-modules, it's not working for me at the
> moment, so that's something we should probably try to address before
> 0.9.2 if possible]
It compiles for me by make check fails in 14 test (but openvzutilstest
works fine), I'll try to fix that.
>> +#else
>> +
>> +int main(void)
>> +{
>> + Â Âreturn 77; /* means 'test skipped' for automake */
>
> s/77/EXIT_AM_SKIP/ from testutils.h, to avoid a magic number.
>
> ACK with that nit fixed.
Thanks, pushed.
Matthias
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list