Re: [PATCH 6/9] Fix error propagation in finish method for v3 migration

Matthias Bolte <matthias.bolte@xxxxxxxxxxxxxx> · Wed, 25 May 2011 10:42:39 +0200

2011/5/24 Daniel P. Berrange <berrange@xxxxxxxxxx>:
> Even when failing to start CPUs, the finish method was returning
> a success result. Fix this so that the QEMU process is killed
> off when finish fails under v3 protocol. Also rename the
> killOnFinish boolean to 'v3proto' to make it clearer that this
> is a tunable based on the migration protocol version
>
> * src/qemu/qemu_driver.c: Update for API change
> * src/qemu/qemu_migration.c, src/qemu/qemu_migration.h: Kill
> ÂVM in qemuMigrationFinish if failing to start CPUs
> ---
> Âsrc/qemu/qemu_driver.c Â Â| Â Â8 ++++----
> Âsrc/qemu/qemu_migration.c | Â 37 ++++++++++++++++++++++++++++++++-----
> Âsrc/qemu/qemu_migration.h | Â Â5 +++--
> Â3 files changed, 39 insertions(+), 11 deletions(-)
>

ACK.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list