Re: [PATCH 1/9] Extend v3 migration protocol to allow app supplied XML for target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/5/24 Daniel P. Berrange <berrange@xxxxxxxxxx>:
> This extends the v3 migration protocol such that the
> virDomainMigrateBegin3 and virDomainMigratePerform3
> methods accept an application supplied XML config for
> the target VM.
>
> If the 'xmlin' parameter is NULL, then Begin3 uses the
> current guest XML as normal. A driver implementing the
> Begin3 method should either reject all non-NULL 'xmlin'
> parameters, or strictly validate that the app supplied
> XML does not change guest ABI.
>
> The Perform3 method also needed the xmlin parameter to
> cope with the Peer2Peer migration sequence.
>
> NB it is not yet possible to use this capability since
> neither of the public virDomainMigrate/virDomainMigrateToURI
> methods have a way to pass in XML.
>
> * daemon/remote.c, src/remote/remote_driver.c,
> Âsrc/remote/remote_protocol.x, src/remote_protocol-structs:
> ÂAdd 'remote_string xmlin' parameter to begin3/perform3
> ÂRPC messages
> * src/libvirt.c, src/driver.h, src/libvirt_internal.h: Add
> Â'const char *xmlin' parameter to Begin3/Perform3 methods
> * src/qemu/qemu_driver.c, src/qemu/qemu_migration.c,
> Âsrc/qemu/qemu_migration.h: Pass xmlin parameter around
> Âmigration methods
> ---
> Âdaemon/remote.c       Â|  Â8 +++++-
> Âsrc/driver.h         |  Â2 +
> Âsrc/libvirt.c        Â|  49 ++++++++++++++++++++++++++++++-----------
> Âsrc/libvirt_internal.h    |  Â2 +
> Âsrc/qemu/qemu_driver.c    |  Â8 ++++--
> Âsrc/qemu/qemu_migration.c  Â|  17 ++++++++++++--
> Âsrc/qemu/qemu_migration.h  Â|  Â2 +
> Âsrc/remote/remote_driver.c  |  Â4 +++
> Âsrc/remote/remote_protocol.x | Â Â2 +
> Âsrc/remote_protocol-structs Â| Â Â2 +
> Â10 files changed, 75 insertions(+), 21 deletions(-)
>

ACK.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]