On Tue, May 24, 2011 at 04:34:47PM +0100, Stefan Hajnoczi wrote: > On Tue, May 24, 2011 at 3:13 PM, Adam Litke <agl@xxxxxxxxxx> wrote: > Looks like we're close to converging here. I am going to update the > QEMU-side patches to this new API. > > > /** > > Â* virDomainBlockPull: > > Â* @dom: pointer to domain object > > Â* @path: Fully-qualified filename of disk > > Â* @pos: A pointer to a virDomainBlockPullInfo structure, or NULL > > Â* @flags: currently unused, for future extension > > Â* > > Â* Populate a disk image with data from its backing image. ÂOnce all data from > > Â* its backing image has been pulled, the disk no longer depends on a backing > > Â* image. ÂThis function works incrementally, performing a small amount of work > > Â* each time it is called. ÂWhen successful, @pos is updated with the current > > Â* progress. > > Â* > > Â* Returns -1 in case of failure, 0 when successful. > > Â*/ > > int         virDomainBlockPull(virDomainPtr dom, > >                    const char *path, > >                    virDomainBlockPullInfoPtr *pos, > > I think you mean: > virDomainBlockPullInfoPtr info, This proposal looks fine with that obvious typo fix. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list