On 05/19/2011 05:21 AM, Daniel P. Berrange wrote:
> To allow new mandatory migration cookie data to be introduced,
> add support for checking supported feature flags when parsing
> migration cookie.
>
> * src/qemu/qemu_migration.c: Feature flag checking in migration
> cookie parsing
> ---
> src/qemu/qemu_migration.c | 56 ++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 55 insertions(+), 1 deletions(-)
ACK with one nit:
> @@ -296,6 +309,12 @@ static void qemuMigrationCookieXMLFormat(virBufferPtr buf,
> virBufferEscapeString(buf, " <hostname>%s</hostname>\n", mig->hostname);
> virBufferAsprintf(buf, " <hostuuid>%s</hostuuid>\n", hostuuidstr);
>
> + for (i = 0 ; i < QEMU_MIGRATION_COOKIE_FLAG_LAST ; i++) {
> + if (mig->flagsMandatory & (1 << i))
> + virBufferAsprintf(buf, " <feature name='%s'/>",
Need a newline in this output, unless you like:
<feature name='abc'/> <feature name='def'/>
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list