Re: [PATCH 10/10] Add a plugin for the 'sanlock' project

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 19, 2011 at 6:24 AM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote:
> Sanlock is a project that implements a disk-paxos locking
> algorithm. This is suitable for cluster deployments with
> shared storage.
>
> * src/Makefile.am: Add dlopen plugin for sanlock
> * src/locking/lock_driver_sanlock.c: Sanlock driver
> ---
> Âlibvirt.spec.in          |  11 +
> Âpo/POTFILES.in          Â|  Â1 +
> Âsrc/Makefile.am          |  12 +
> Âsrc/libvirt_private.syms     Â|  Â1 +
> Âsrc/locking/lock_driver_sanlock.c | Â413 +++++++++++++++++++++++++++++++++++++
> Â5 files changed, 438 insertions(+), 0 deletions(-)
> Âcreate mode 100644 src/locking/lock_driver_sanlock.c
>

<snip>

Daniel,

How does the dependency magic for sanlock work here? It appears that
there will be an automagical dependency on libsanlock when its
installed. It might be a good idea to provide a ./configure script
knob to enable/disable this piece.

Additionally, I see you've added virAllocVar to the syms list but I
don't see it used anywhere else in the context of this patch. Not sure
if I'm missing something.

-- 
Doug Goldstein

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]