On Wed, May 18, 2011 at 11:47:25AM -0600, Eric Blake wrote: > On 05/18/2011 11:08 AM, Daniel P. Berrange wrote: > > The v2 migration protocol had a limit on cookie length that was > > too small to be useful for QEMU. Avoid generating cookies with > > v2 protocol, so that old libvirtd can still reliably migrate a > > guest to new libvirtd uses v2 protocol. > > > > * src/qemu/qemu_driver.c: Avoid migration cookies with v2 > > migration > > --- > > src/qemu/qemu_driver.c | 27 ++++++++++++++++++++------- > > 1 files changed, 20 insertions(+), 7 deletions(-) > > Is it any better to try generating the cookie, and only discard it if it > was too long, than to blindly skip the cookie? Or are we pretty sure > that the cookie will always be longer than the old limit (256, if I'm > reading REMOTE_MIGRATE_COOKIE_MAX correctly in remote_protocol.x)? > > If the latter, then ACK. Yep, it is always going to be longer. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list