Re: [PATCHv2 4/6] build: make python optional at configure time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/5/18 Eric Blake <eblake@xxxxxxxxxx>:
> Regression introduced in commit 53cb23f4.
>
> * configure.ac: Let --with-python default to check.
> ---
>
> v2: no change from v1
> v1: https://www.redhat.com/archives/libvir-list/2011-May/msg00412.html
>
> Âconfigure.ac | Â 29 ++++++++++++++++++++---------
> Â1 files changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 8a3de4c..1a9fddd 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1832,12 +1832,12 @@ dnl check for python
> Âdnl
>
> ÂAC_ARG_WITH([python],
> - ÂAC_HELP_STRING([--with-python], [Build python bindings @<:@default=yes@:>@]),[],[with_python=yes])
> + ÂAC_HELP_STRING([--with-python],
> + Â [Build python bindings @<:@default=check@:>@]),[],[with_python=check])
>
> Âif test "$enable_shared:$with_python" = no:yes; then
> - ÂAC_MSG_WARN([Disabling shared libraries is incompatible with building Python extensions.])
> - ÂAC_MSG_WARN([Ignoring --with-python.])
> - Âwith_python=no
> + ÂAC_MSG_ERROR([Disabling shared libraries is incompatible with building
> + Â ÂPython extensions.])
> Âfi

So, now this reports an error when you explicitly enable Python
bindings. But as with_python defaults to check now we might end up
enabling the bindings after this check even though enable_shared is
no. So this check doesn't work correctly anymore.

Matthas

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]