On 05/17/2011 09:48 AM, Eric Blake wrote: > On 05/17/2011 12:20 AM, Hu Tao wrote: >> This new function allows aditional flags to be passed into from > > s/aditional/additional/ > >> +++ b/include/libvirt/libvirt.h.in >> @@ -295,6 +295,12 @@ typedef enum { >> VIR_DOMAIN_SCHED_FIELD_BOOLEAN = 6 /* boolean(character) case */ >> } virSchedParameterType; >> >> +typedef enum { >> + VIR_DOMAIN_SCHEDPARAM_CURRENT = (1 << 0), /* affect current domain state */ > > This should be 0, > >> + VIR_DOMAIN_SCHEDPARAM_LIVE = (1 << 1), /* Affect active domain */ >> + VIR_DOMAIN_SCHEDPARAM_CONFIG = (1 << 2), /* Affect next boot */ > > and these 1 and 2 (1 << 0, 1 << 2). Aargh. I accidentally pushed this commit before adding my changes (I have enough latency connecting to libvirt.git that my 'git push' in one window had not completed by the time my 'git am' in another window had, and 'git push' uses the current HEAD at the time of the remote connection, rather than at the time the git command started). diff --git i/include/libvirt/libvirt.h.in w/include/libvirt/libvirt.h.in index ec32b4b..a174201 100644 --- i/include/libvirt/libvirt.h.in +++ w/include/libvirt/libvirt.h.in @@ -296,9 +296,9 @@ typedef enum { } virSchedParameterType; typedef enum { - VIR_DOMAIN_SCHEDPARAM_CURRENT = (1 << 0), /* affect current domain state */ - VIR_DOMAIN_SCHEDPARAM_LIVE = (1 << 1), /* Affect active domain */ - VIR_DOMAIN_SCHEDPARAM_CONFIG = (1 << 2), /* Affect next boot */ + VIR_DOMAIN_SCHEDPARAM_CURRENT = 0, /* affect current domain state */ + VIR_DOMAIN_SCHEDPARAM_LIVE = (1 << 0), /* Affect active domain */ + VIR_DOMAIN_SCHEDPARAM_CONFIG = (1 << 1), /* Affect next boot */ } virDomainSchedParameterFlags; /** -- Eric Blake eblake@xxxxxxxxxx +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list