2011/5/16 Eric Blake <eblake@xxxxxxxxxx>: > On 05/01/2011 01:57 PM, Matthias Bolte wrote: >> Break long lines and change spacing of keyword arguments to match >> Python style standards better. >> >> No functional change included. >> --- >> Âsrc/esx/esx_vi_generator.py | Â369 ++++++++++++++++++++++++++++-------------- >> Â1 files changed, 246 insertions(+), 123 deletions(-) > > I don't know the python style standards, but I could at least review > this on the grounds of looking like safe whitespace changes. > > ACK. > >> @@ -830,7 +908,8 @@ class Object(Type): >> >> Â Â Â Â Â Â Â Â Âif self.features & Object.FEATURE__LIST: >> Â Â Â Â Â Â Â Â Â Â Âsource += "/* esxVI_%s_SerializeList */\n" % self.name >> - Â Â Â Â Â Â Â Â Â Âsource += "ESX_VI__TEMPLATE__LIST__SERIALIZE(%s)\n\n" % self.name >> + Â Â Â Â Â Â Â Â Â Âsource += "ESX_VI__TEMPLATE__LIST__SERIALIZE(%s)\n\n" \ >> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â% self.name >> >> Â Â Â Â Â# deserilaize > > You may want to do a followup patch to fix typos like this. As this one was the only typo I cloud find in the generator I've just folded the fix into this patch and pushed the result. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list